scidsg / hushline

Hush Line connects whistleblowers with organizations and people who can help.
https://hushline.app
GNU Affero General Public License v3.0
77 stars 21 forks source link

tie alias creation to premium subscriptions #699

Closed brassy-endomorph closed 3 weeks ago

brassy-endomorph commented 1 month ago

fixes #645

glenn-sorrentino commented 1 month ago

Subscribed users get 100 aliases. Single-tenant is unlimited. Free is none.

glenn-sorrentino commented 1 month ago

Will leave comments while testing:

First - In the screenshot, I have not subscribed and have no aliases. the To: string in the user's inbox is only applicable if they have at least one alias.

Screenshot 2024-10-17 at 9 30 01 AM

glenn-sorrentino commented 1 month ago

Other than the comment above, the functionality on the front-end works well!

glenn-sorrentino commented 1 month ago

Noticing during the cancel Screenshot 2024-10-17 at 9 39 30 AM subscription flow that the page isn't redirecting back to the premium page...

brassy-endomorph commented 1 month ago

subscription flow that the page isn't redirecting back to the premium page...

@micahflee you recognize this?

glenn-sorrentino commented 1 month ago

Also when I click "Cancel Now" I'm directed to the disable auto-renew page, but that's a different feature from canceling...

cancel-sub

brassy-endomorph commented 1 month ago

Those sound like bugs for other tickets because they're not directly related to this PR and shoulnd't be addressed here. That will just make this ticket massive and more difficult to get merged. I can do that in a followup too, but it's not really relevant to the changeset I'm proposing.

glenn-sorrentino commented 1 month ago

Those sound like bugs for other tickets because they're not directly related to this PR and shoulnd't be addressed here. That will just make this ticket massive and more difficult to get merged. I can do that in a followup too, but it's not really relevant to the changeset I'm proposing.

By "those", which of the above do you mean?

brassy-endomorph commented 1 month ago

https://github.com/scidsg/hushline/pull/699#issuecomment-2420027144

and

https://github.com/scidsg/hushline/pull/699#issuecomment-2420019089

Canceling / disabling autorenew should be separate tickets