search

scieloorg / opac_5

SciELO - On-line Public Access Catalog - OPAC
https://www.scielo.br
BSD 2-Clause "Simplified" License
2 stars 7 forks source link

Adiciona Serviço MinIO ao Docker Compose #147

Closed samuelveigarangel closed 4 months ago

samuelveigarangel commented 4 months ago

O que esse PR faz?

Esta Pull Request adiciona a configuração necessária para incluir o serviço MinIO no arquivo docker-compose.yml.

Onde a revisão poderia começar?

pelo commit

Como este poderia ser testado manualmente?

  1. make up

Algum cenário de contexto que queira dar?

N/A

Screenshots

N/A

Quais são tickets relevantes?

N/A

Referências

N/A

gitguardian[bot] commented 4 months ago

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [9302036](https://dashboard.gitguardian.com/workspace/155288/incidents/9302036?occurrence=157837473) | Triggered | Generic Password | fe48b73473565070a0883b1d0cd751bd31e0b419 | docker-compose-dev.yml | [View secret](https://github.com/scieloorg/opac_5/commit/fe48b73473565070a0883b1d0cd751bd31e0b419#diff-66566bf2427d05383e7f510e289c17b88283dec58b1f347bf35c21125a100ad8R192) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_password#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.