scieloorg / scielo-manager

Management tool for cataloging journals and articles, available in a SaaS model. It acts as a central metadata backbone for all the systems and services of SciELO.
http://docs.scielo.org/projects/scielo-manager/en/latest/
BSD 2-Clause "Simplified" License
16 stars 11 forks source link

*journalmanager.tasks.link_article_to_issue* não trata artigos vinculados a números suplementares e especiais. #1248

Open gustavofonseca opened 8 years ago

gustavofonseca commented 8 years ago

Exceção que está sendo levantada atualmente:

Task journalmanager.tasks.link_article_to_issue with id b0a0047f-ee24-424a-beac-f7ab25773295 raised exception:
'MultipleObjectsReturned("get() returned more than one Issue -- it returned 2! Lookup parameters were {\'volume\': \'36\', \'number\': \'4\', \'publication_year\': \'2002\'}",)'

Task was called with args: (53238,) kwargs: {}.

The contents of the full traceback was:

Traceback (most recent call last):
  File "/var/www/.virtualenvs/scielomanager/lib/python2.7/site-packages/celery/app/trace.py", line 240, in trace_task
    R = retval = fun(*args, **kwargs)
  File "/var/www/.virtualenvs/scielomanager/lib/python2.7/site-packages/celery/app/trace.py", line 438, in __protected_call__
    return self.run(*args, **kwargs)
  File "/var/www/manager_scielo_org/scielomanager/journalmanager/tasks.py", line 184, in link_article_to_issue
    volume=volume, number=issue, publication_year=year)
  File "/var/www/.virtualenvs/scielomanager/lib/python2.7/site-packages/django/db/models/manager.py", line 131, in get
    return self.get_query_set().get(*args, **kwargs)
  File "/var/www/.virtualenvs/scielomanager/lib/python2.7/site-packages/django/db/models/query.py", line 368, in get
    % (self.model._meta.object_name, num, kwargs))
MultipleObjectsReturned: get() returned more than one Issue -- it returned 2! Lookup parameters were {'volume': '36', 'number': '4', 'publication_year': '2002'}
gustavofonseca commented 8 years ago

O pull request #1250 é um work around que evita os erros, mas não resolve o problema.

lpanebr commented 8 years ago

será que ao invés de simplificar o scielo manager terão que complicar o SPS usando <supplement>?[1]

...
<article-meta>
...
<volume>52</volume>
<issue>1</issue>
<supplement>1</supplement>
<fpage>437</fpage>
<lpage>467</lpage>
...
</article-meta>
...

[1] http://jats.nlm.nih.gov/publishing/tag-library/1.1d1/n-xnd0.html

gustavofonseca commented 8 years ago

@lpanebr, está falando sobre o ticket #1249? Se sim, estamos discutindo internamente sobre considerar o elemento <supplement> e algum outro para denotar números especiais, e assim reduzir essa carga semântica do elemento <issue>. Mas trata-se de outro ticket rs.

lpanebr commented 8 years ago

Sim. Vou comentar lá.