search

sciencefair-land / sciencefair

The futuristic, fabulous and free desktop app for working with scientific literature :microscope: :book:
https://sciencefair-app.com
MIT License
603 stars 52 forks source link

"Linked items" in modal box do nothing (Ubuntu 16.04, v. 1.0.3) #101

Closed pvanheus closed 7 years ago

pvanheus commented 7 years ago

Clicking "sciencefair" in the top right corner opens a model window:

image

There are three items - code, website and chat that appear to be links. Clicking on them does nothing.

blahah commented 7 years ago

Hmm, these are just buttons with

btn.onclick = e => {
  e.preventDefault()
  opn(btnurl)
}

This works on OSX and Windows.

@sindresorhus any ideas why this would die without error on Ubuntu?

sindresorhus commented 7 years ago

Don't use opn with Electron. Electron has its own method for this: https://electron.atom.io/docs/api/shell/#shellopenitemfullpath

blahah commented 7 years ago

Ah, thanks @sindresorhus - actually you mentioned this before but I moved to opn rather than the electron native interface by accident. Sorry for troubling you again!