search

sciencefair-land / sciencefair

The futuristic, fabulous and free desktop app for working with scientific literature :microscope: :book:
https://sciencefair-app.com
MIT License
603 stars 52 forks source link

[v1.0.4] SyntaxError: Failed to execute 'measure' on 'Performance': The mark 'end-51705099-choo.emit('log:debug')' does... #108

Closed blahah closed 7 years ago

blahah commented 7 years ago

https://sentry.io/codeforscience/sciencefair/issues/302922970/

SyntaxError: Failed to execute 'measure' on 'Performance': The mark 'end-51705099-choo.emit('log:debug')' does not exist.
  at None (/Applications/ScienceFair.app/Contents/Resources/app.asar/client/index.html)

This is an error related to choo v6, and we can avoid it by restoring choo-log and settting localStorage.logLevel = 'error'.

blahah commented 7 years ago

This error is still being thrown, but after discussion with @yoshuawuyts it's clear that it is not causing any harm. So, we'll release with the error still being thrown, and try to get it tidied up in the next release. I'll also ignore it on sentry.

blahah commented 7 years ago

actually the error is flooding sentry, so reopening

blahah commented 7 years ago

fixed in https://github.com/yoshuawuyts/nanotiming/pull/5