search

sciencefair-land / sciencefair

The futuristic, fabulous and free desktop app for working with scientific literature :microscope: :book:
https://sciencefair-app.com
MIT License
603 stars 52 forks source link

stop blocking fullscreen mode for macOS & Windows users #109

Closed katrinleinweber closed 7 years ago

katrinleinweber commented 7 years ago

Hello and thanks for working on this neat app :-)

Is there are specific reason why fullscreen: is set to false? I haven't coded for Electron before, but from its BrowserWindow docu I gather that fullscreenable: true would keep the current default behaviour, but additionally enable full-screen mode :-)

Because it was a quick change, I already PR'ed it:

blahah commented 7 years ago

@katrinleinweber whoa, this is awesome, thanks!

When fullscreen is set to true, the app opens maximised by default (or at least it did when I set that options). I didn't even realise there was an option to allow true fullscreen, and am very happy to have it. Thanks so much!

katrinleinweber commented 7 years ago

How it should open is very much personal preference, I guess. Me: fullscreen! Many other Mac users I saw prefer unmaximised even.

blahah commented 7 years ago

Agreed - I turned off that particular setting because users asked for it to be turned off, but I think your PR gives us the ideal situation when users who want it can fullscreen 👌🏾👍🏽