Closed katrinleinweber closed 7 years ago
@katrinleinweber whoa, this is awesome, thanks!
When fullscreen
is set to true, the app opens maximised by default (or at least it did when I set that options). I didn't even realise there was an option to allow true fullscreen, and am very happy to have it. Thanks so much!
How it should open is very much personal preference, I guess. Me: fullscreen! Many other Mac users I saw prefer unmaximised even.
Agreed - I turned off that particular setting because users asked for it to be turned off, but I think your PR gives us the ideal situation when users who want it can fullscreen ππΎππ½
Hello and thanks for working on this neat app :-)
Is there are specific reason why
fullscreen:
is set tofalse
? I haven't coded for Electron before, but from itsBrowserWindow
docu I gather thatfullscreenable: true
would keep the current default behaviour, but additionally enable full-screen mode :-)Because it was a quick change, I already PR'ed it: