sciencefair-land / sciencefair

The futuristic, fabulous and free desktop app for working with scientific literature :microscope: :book:
https://sciencefair-app.com
MIT License
604 stars 52 forks source link

Move defaultsources.js file system work to main thread #146

Closed greggraf closed 7 years ago

greggraf commented 7 years ago

Created a new file app/lib/defaultsources.js and added it to app/lib/setup.js so that file system checks occur in the main thread.e render

Reworked app/client/models/defaultsources.js to get the datasource key via IPC (in the case when 'datasources:add' needs to be triggered.

Ultimately I hope the logic in app/client/lib/datasource.js (which can be invoked by 'datasources:add') will be similarly divided between the main and render threads

blahah commented 7 years ago

Looks good @greggraf ! LGTM :shipit: