npm run rebuild no longer needed, taken care of by postinstall step

sciencefair-land / sciencefair

The futuristic, fabulous and free desktop app for working with scientific literature :microscope: :book:

https://sciencefair-app.com

MIT License

603 stars 52 forks source link

npm run rebuild no longer needed, taken care of by postinstall step #151

Closed ralphtheninja closed 7 years ago

ralphtheninja commented 7 years ago

npm run rebuild is done in postinstall step here https://github.com/codeforscience/sciencefair/blob/27463c242499b90196e0982257ea7acaec747c55/app/package.json#L9

ralphtheninja commented 7 years ago

Hmm, how can travis and appveyor fail if I only changed the README?

blahah commented 7 years ago

@ralphtheninja travis and appveyor aren'y running tests, they are just release build scripts. They shouldn't be running on PRs probably - I'll look into that.

blahah commented 7 years ago

This PR however is definitely not breaking :) thanks! LGTM :shipit: