search

sciencefair-land / sciencefair

The futuristic, fabulous and free desktop app for working with scientific literature :microscope: :book:
https://sciencefair-app.com
MIT License
604 stars 52 forks source link

Update the json loader for unkown authors. #176

Closed SirRujak closed 5 years ago

SirRujak commented 5 years ago

It was creating a string of 'unkown' for the author entry rather than a dictionary containing surname and given-names as is expected later in the code. In creating the PMC database I ran across this as an error. I am pretty sure I got the keys correct given the code in app/client/lib/paper.js at line 133. That was where I first noticed the error and hopefully this is enough to allow some slightly less clean datasets to be used.

P.S. Here is the first article I found that caused this issue. It is a correction so the PubMed database doesn't have a listed author for it.

bencevans commented 5 years ago

LGTM. Travis error being thrown in this PR appears to be fixed by #177.

SirRujak commented 5 years ago

I just checked this and it turns out it wasn't quite the correct fix. It appears I needed a list of objects rather than just an object. I'll close this one for now and make a new pull with the proper change.