sciencefair-land / sciencefair

The futuristic, fabulous and free desktop app for working with scientific literature :microscope: :book:
https://sciencefair-app.com
MIT License
604 stars 52 forks source link

Migrate to electron v1.6.2 #43

Closed blahah closed 7 years ago

blahah commented 7 years ago

This PR moves us to electron v1.6.2. Previously we were falling way behind improvements in electron because there were binary ABI compatibility issues between node, electron and chromium v8. Those have been resolved by a combination of fixes and improvements in the toolchain.

We now use electron-rebuild as a postinstall to make sure binary modules are kept compatible with electron.

Note that theres a bug in a module in the dependency tree that causes harmless errors to be printed to the electron console: https://github.com/codeforscience/sciencefair/issues/42