sciencefair-land / sciencefair

The futuristic, fabulous and free desktop app for working with scientific literature :microscope: :book:
https://sciencefair-app.com
MIT License
604 stars 52 forks source link

"Open in Finder" #65

Open mafintosh opened 7 years ago

mafintosh commented 7 years ago

Would be nice to have an "Open in Finder" option when reading a paper that just open the folder where the data is stored

blahah commented 7 years ago

For cross-platform perhaps "Open data folder"?

blahah commented 7 years ago

And we're already using https://www.npmjs.com/package/open for URLs, so this should be trivially easy to implement.

sindresorhus commented 7 years ago

Since you're using Electron, I think it would be better to use shell.showItemInFolder().

blahah commented 7 years ago

thanks @sindresorhus, any particular reason?

sindresorhus commented 7 years ago

@blahah It's better as it uses native APIs instead of being a wrapper over some command-line tools. I'm by the way the maintainer of opn, a maintained and better alternative to the open module you mention.

blahah commented 7 years ago

Thanks @sindresorhus - looks like we should switch from open to opn, and we'll use shell.showItemInFolder() as suggested.