search

sciencefair-land / sciencefair

The futuristic, fabulous and free desktop app for working with scientific literature :microscope: :book:
https://sciencefair-app.com
MIT License
604 stars 52 forks source link

modal can't be dismissed using escape key #68

Closed yoshuawuyts closed 7 years ago

yoshuawuyts commented 7 years ago

I'm big on keybindings I guess haha; seemed like unexpected behavior to me.

I should probs update https://github.com/shama/modal-element at some point, but ref code for this can be found here: https://github.com/yoshuawuyts/base-elements/blob/master/modal.js

blahah commented 7 years ago

@yoshuawuyts yeah there's def a load more keybindings needed. O pretty much only made them work for manipulating selections of results (except ctrl-a)

issues for any you notice missing are greatly appreciated :)

blahah commented 7 years ago

(issues or PRs!)