sciencehistory / chf-sufia

sufia-based hydra app
Other
9 stars 4 forks source link

GPDR design changes #1065

Closed eddierubeiz closed 6 years ago

eddierubeiz commented 6 years ago

1) Change the footer by adding a link to the privacy policy.

jrochkind commented 6 years ago

makes sense to me.

I don't know if we need a third-party dependency for this at all. It should be easy enough to write our own code to check and set a cookie.

It could perhaps be entirely front-end JS. The HTML for the banner is there in the DOM anyway, but display:none'd, the JS checks for the cookie, if it's not there, it shows the banner, with a JS trigger on the "ok" button that hides the banner and sets the cookie.

I don't think we need a third-party dependency for that, it's straightforward code.

eddierubeiz commented 6 years ago

Great. Simple and maintainable.

jrochkind commented 6 years ago

maybe go ahead and do point 1 first, as a separate PR, so we can get that deployed, and then work on the somewhat more complex point 2.

jrochkind commented 6 years ago

I don't know if there are any concerns about putting the copyright statement specifically on our web site, I think maybe there had previously been concerns about accidentally implying that we held copyright on our assets (which we generally don't), and that might be why we don't have the copyright symbol already. But I may have gotten the wrong impression, I wasn't involved in any decision that may have happened to leave out the copyright statement thus far, that was Michelle.

@catlu @RonBrashear

RonBrashear commented 6 years ago

Interesting. I don’t recall any conversations about not putting the copyright statement on the digital collections site. Since it is on the SHI website in general, I’m surprised we weren’t asked to have it on there.

I wonder what other institutions do?


Ronald Brashear Arnold Thackray Director Othmer Library of Chemical History t. +1.215.873.8284

Science History Institute Chemistry • Engineering • Life Sciences 315 Chestnut Street • Philadelphia, PA 19106 • U.S.A. sciencehistory.orghttps://www.sciencehistory.org/

The Chemical Heritage Foundation is now the Science History Institute. For more information visit sciencehistory.org. https://www.sciencehistory.org/ From: Jonathan Rochkind [mailto:notifications@github.com] Sent: Wednesday, May 23, 2018 11:43 AM To: sciencehistory/chf-sufia chf-sufia@noreply.github.com Cc: Brashear, Ronald RBrashear@ScienceHistory.org; Mention mention@noreply.github.com Subject: Re: [sciencehistory/chf-sufia] GPDR design changes (#1065)

I don't know if there are any concerns about putting the copyright statement specifically on our web site, I think maybe there had previously been concerns about accidentally implying that we held copyright on our assets (which we generally don't), and that might be why we don't have the copyright symbol already. But I may have gotten the wrong impression, I wasn't involved in any decision that may have happened to leave out the copyright statement thus far, that was Michelle.

@catluhttps://github.com/catlu @mhpmillerhttps://github.com/mhpmiller @RonBrashearhttps://github.com/RonBrashear

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/sciencehistory/chf-sufia/issues/1065#issuecomment-391395793, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AkFkBJU_u01B6QKxLShHOym6erjGnW6kks5t1YOdgaJpZM4UKq4H.

eddierubeiz commented 6 years ago

Good point, @RonBrashear. I can see making the argument that putting a copyright statement at the bottom of the Digital Collections footer might create the wrong impression regarding a) the codebase at https://github.com/sciencehistory/chf-sufia/, or b) the content in the repository.

But for now I'm going to match the design on the main site. Easy enough to remove the copy if we decide otherwise.

mhpmiller commented 6 years ago

I think the copyright-in-footer is pretty widely recognized as "applies to the content of the website except where we say otherwise" (and the rights statements are pretty clear and obvious). Penn, our favorite institutional comp, uses a footer copyright notice.

mhpmiller commented 6 years ago

And if there was a more explicit concern about copyfraud, we could always promote Rights and Rights Holder metadata to be displayed alongside Creator and Subject on Collection pages, in searches, etc.

eddierubeiz commented 6 years ago

This is working in production. Closing this issue.