Social media icons broken

sciencehistory / chf-sufia

sufia-based hydra app

Other

9 stars 4 forks source link

Social media icons broken #341

Closed hackartisan closed 7 years ago

hackartisan commented 7 years ago

tumblr, google

We will test closer to soft launch when the firewall is gone.

hackartisan commented 7 years ago

I tried these upstream. It seems that it doesn't really work due to the restricted access maybe? Results weren't conclusive enough to file a bug report there:

Facebook gave me an error "Can't Load URL: The domain of this URL isn't included in the app's domains. To be able to load this URL, add all domains and subdomains of your app to the App Domains field in your app settings."
Twitter works fine
Google plus brings me to a 'post' page but after trying to generate a preview for a little while flashes a brief message that the URL is invalid.
tumblr brings me to a "sign up" page (I don't have a tumblr account).

jrochkind commented 7 years ago

Probably not working because our app is firewalled, indeed. Facebook def needs to be able to fetch your URL to work properly. Not sure if there's a good way to ensure this is working before soft launch, when soft launch is when this becomes visible to facebook etc!

MDiMeo commented 7 years ago

Sounds like the problem with Google+ is the same as that with Facebook: the firewall.

The bigger issue is Tumblr. I know @hackmastera said above that it takes her to log in page, but it takes me to a 404 page. I had Ashley try it because she regularly posts to Tumblr for Othmeralia and she also got "page not found".

Also, Zach in Communications had previously asked me if we could add a Pinterest icon. If that's something we want, I can either keep it here or make a separate ticket for that and file it in the backlog.

jrochkind commented 7 years ago

@MDiMeo I'd choose making a separate ticket.

Not really sure what to do with any of these without our app being public. Perhaps we can make it temporarily public with a robots.txt. Or figure out what IP's to whitelist for all the social networks, but that could be hard.

Is tumblr a requirement for soft launch, or might we want to just remove it? (Do people actually still use tumblr? I don't think anyone uses google+!)

hackartisan commented 7 years ago

the testing I did was on the sufia master at the time. Maybe we should check tumblr again after we hit 7.3

hackartisan commented 7 years ago

We could open up a dev box to the world for some development / testing of this. I like the robots.txt idea.

jrochkind commented 7 years ago

I believe these are probably working fine, if the app can be reached by the social media sites.

Do we want to make a dev box that's open to the world to confirm my belief, or just close this?

hackartisan commented 7 years ago

We decided to test this in the week or so before soft launch; relabeling as testing

MDiMeo commented 7 years ago

Now that the firewall is down, we were able to test this. Facebook, Twitter, Google+, and Tumblr icons each bring the user to a preview page for sharing.