sciencehistory / scihist_digicoll

Science History Institute Digital Collections
Other
11 stars 0 forks source link

Reconsider data model for Interviewee Biographies #1077

Closed jrochkind closed 1 year ago

jrochkind commented 3 years ago

We did it as a many-to-many between OralHistoryContent (a supplement to the Work), and some IntervieweeBiography models (in their own db table).

At the last minute, we realized we might prefer this as embedded AttrJson models, an array of embedded json IntervieweeBiographies or whatever.

While the embedded approach would require copy-paste instead of re-use of "shared" biography, shared biography is actually pretty rare, and it might have the advantages:

One disadvantage is figuring out the right patterns to use Rails forms with this kind of embedded large model, we haven't really done before.

Not sure, but we were leaning in this direction... but realized at this point in the game we didn't want to go rewriting what we ere already had, what we had was good enough.

but worth making a note of and considering later.

jrochkind commented 3 years ago

@eddierubeiz Can you share your thoughts or intents in moving this to "Review" column? Based on our previous discussion, I was thinking this was probably something to leave until after the microsite is turned off, not something for immediate discussion, and it's of course not something we're done with yet.

jrochkind commented 1 year ago

you know what, it is how it is for now, it's working -- there's no reason to bikeshed it post-release, let's close this for now.