search

sciencehistory / scihist_digicoll

Science History Institute Digital Collections
Other
13 stars 0 forks source link

Include parents and collections when looking for finding aids #2691

Closed eddierubeiz closed 3 months ago

eddierubeiz commented 4 months ago

Part of Ref #2627

See in particular https://github.com/sciencehistory/scihist_digicoll/issues/2627#issuecomment-2274186057 which spells out the metadata guidelines for which works have and don't have finding aid metadata directly attached to them.

jrochkind commented 4 months ago

@eddierubeiz You write 'rather than', but the spec I was anticipating was to look in both places. Does that seem workable?

eddierubeiz commented 4 months ago

Missed your comment the other day, but yeah, you're of course right. I'm also looking at parent works (and their collections) in this draft version of the PR. Once Sarah adds links to the child works mentioned in the report, I can amend the PR to ignore parent works before we merge (very small change). Or we can keep it the way it is - not a big deal either way. We can decide when we're all in the office :) .

eddierubeiz commented 3 months ago

Note: I'm replacing a call to method RelatedLinkFilter#finding_aid_related_links and replacing it with a couple lines of inline code. It makes more sense now that we're listing the finding aids for more than one model instance.

jrochkind commented 3 months ago

Nice, love how little this took!