search

sciencehistory / scihist_digicoll

Science History Institute Digital Collections
Other
13 stars 0 forks source link

Fix flaky Github CI test #2728

Closed eddierubeiz closed 3 months ago

eddierubeiz commented 3 months ago

Ref https://github.com/sciencehistory/scihist_digicoll/issues/2721 . The corrected test runs reliably in CI; I ran it fifty times and it didn't fail.

jrochkind commented 3 months ago

it annoys my sensibilities to have to do this hacky thing, but I don't understand any other possible solution!

I think it just needs to wait for the Javascript event handlers to actually be attached to handle the click! Not sure what can be done about that.

Thanks for figuring this out! Will be super nice not to have it failing!