search

sciencehistory / scihist_digicoll

Science History Institute Digital Collections
Other
13 stars 0 forks source link

Deal better with logging to rails log after ActiveJob::DeserializationError #2730

Closed eddierubeiz closed 3 months ago

eddierubeiz commented 3 months ago

This took two tries, but it's actually a simple problem - a ApplicationJob does not have an id but it does have a job_id. (Putting id in the error message was throwing a NoMethodError.) Ref #2626

jrochkind commented 3 months ago

Thanks!

Not having the job id in the error line is unfortunate, and won't allow the error line to tell us much, or be findable when we're looking for what hapepend with a given job id.

If we're going ot do this, maybe at least log "No job id available" or something, instead of just a blank space more easily missed?

eddierubeiz commented 3 months ago

Good call - done!