search

sciencehistory / scihist_digicoll

Science History Institute Digital Collections
Other
13 stars 0 forks source link

Fix sort on admin work page. #2763

Closed eddierubeiz closed 1 month ago

eddierubeiz commented 1 month ago

Ref #2762 Classic blunder - should have used order! instead of order.

jrochkind commented 1 month ago

Sorry if this is obvious and i'm being annoying, but important to have actually verified the test failed before fix, when adding a regression test. Sometimes you think you've written a good test, but it turns out it was green before fix too!

eddierubeiz commented 1 month ago

Yup! The test fails with order and passes with order!.