search

sciencemesh / cs3api4lab

CS3APIs Jupyterlab connector
Apache License 2.0
4 stars 11 forks source link

Added grpc locks support #209

Closed mateusz-garlacz closed 1 year ago

mateusz-garlacz commented 1 year ago

I fixed most of the CodeQL warnings. The remaining ones will have to stay, because our tests structure enforce overwriting attributes in subclasses

glpatcern commented 1 year ago

I guess it's fine for the overwrite of attributes in subclasses (though it's a bit of an edge case), but the following warnings: Missing call to __init__ during object initialization Correspond to missing super().__init__() calls. IMHO these must be fixed...

mateusz-garlacz commented 1 year ago

all checks are green now