search

sciencemine / digital-signage

4 stars 0 forks source link

Full video not playing when selected #99

Closed HumbleHominid closed 7 years ago

HumbleHominid commented 7 years ago

An idle timeout is being started when a new video is selected to be played causing only the first 15s to be played before it resets back to the background.

HumbleHominid commented 7 years ago

inputCallback was being called after the onSelectedCallback causing the video to start playing and then having the timer reset immediately afterwords.

Areid406 commented 7 years ago

So you’re saying the call to inputCallback was not necessary?

~Alex

On Jul 14, 2017, at 1:00 PM, Michael Fryer notifications@github.com<mailto:notifications@github.com> wrote:

inputCallback was being called after the onSelectedCallback causing the video to start playing and then having the timer reset immediately afterwords.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/sciencemine/digital-signage/issues/99#issuecomment-315440636, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANkKuT4rhcml3OTbuPtK5dSk-OaL0SOLks5sN7qygaJpZM4OYmty.

HumbleHominid commented 7 years ago

Fixed with https://github.com/sciencemine/digital-signage/commit/c8687a93ed52b27f97859e93aca4225babf744f3

HumbleHominid commented 7 years ago

It probably isn't necessary, for what we are using at least, to be calling the input callback on a select event. However, it might be in the future for some reason. To allow for future proofing I altered the order in which the callbacks are being initiated.