MNT: Replace pkg_resources usage

scientific-python / action-towncrier-changelog

GitHub Action to check towncrier changelog

BSD 3-Clause "New" or "Revised" License

2 stars 5 forks source link

MNT: Replace pkg_resources usage #8

Closed pllim closed 11 months ago

pllim commented 11 months ago

Replace pkg_resources usage because it is deprecated. Also bump Ubuntu and Python versions.

Fix #7

pllim commented 11 months ago

I think it works, see https://github.com/astropy/astropy/pull/15738 logs for Check PR change log / Check if towncrier change log entry is correct (pull_request)

pllim commented 11 months ago

Hmm... I tested "missing changelog" and "no changelog required" cases. I can test the "change log required and exists" tomorrow and see unless you beat me to it.

bsipocz commented 11 months ago

I suppose it's all good then, the missing entry was definitely running after the affected piece of code in this PR (though as I see the label skip is after this one, too.)

pllim commented 11 months ago

I think it is fine, looking at https://github.com/astropy/astropy/actions/runs/7216980660/job/19664067707?pr=15743

Shall we merge? 😸