Closed albertcthomas closed 8 months ago
@albertcthomas Thank you so much for this contribution! I have been on leave, but will review when I'm back.
@albertcthomas Thank you so much for this contribution! I have been on leave, but will review when I'm back.
No worries. I'm also a bit slow on this... Thanks @tupui for the great comments, it's very appreciated to get some feedbacks on this post, I'm learning additional stuffs while doing this. I'll integrate them ASAP.
No worries. I'm also a bit slow on this...
I dealt with the comments made by @tupui. I will just re-read what I wrote after getting some sleep and push it :)
By the way I would like to add one sentence to thank the reviewers that made this blog post better than it was (like @tupui and others if I got other reviews) and other people like @stefanv for suggesting putting my blog post here. Is that OK with the scientific python blog?
Ok course, thank you 😃 This is really your post and we want to let people have their voice and write as their feel like. (And I hope we managed to do that here too 😅). We think it can be more interesting and engaging if we do as little editorial edits as possible to retain everyone's own intent, vision and ideas.
I think I addressed all your comments @tupui. Let me know if there is anything left. Thanks again!
Ok course, thank you 😃 This is really your post and we want to let people have their voice and write as their feel like. (And I hope we managed to do that here too 😅). We think it can be more interesting and engaging if we do as little editorial edits as possible to retain everyone's own intent, vision and ideas.
I will add one then.
Also could you please let me know before merging this PR? I'd like to read it one last time before it goes live :)
Thanks a lot for the new reviews, I committed the easy suggestions, I will incorporate more of them later.
Sorry again for the delay, everything looks good to me! Thanks again for the reviews and feedbacks. I'm not sure why pre-commit is failing... Not sure if I should also change the date of the blog post.
Fixed the pre-commit!
OK to merge for me if you have no further comments :). Thanks again for the constructive comments
Excellent, I think we're good to go! Thanks so much @albertcthomas.
In it goes! Thanks so much, Albert! 🎉
Great! thanks a lot for reaching out and the reviews :)
Blog post on good practices with numpy RNGs (and RNGs in general but focused on numpy features). This is a blog post that I published on my personal page and @stefanv suggested to re-publish it here.
I should make sure it is up-to-date with the recent numpy developments. Some parts could also be changed. I'm opening the PR so we can start discussing about this post.
@stefanv (or anyone else,) let me know if you wanted to add something to this post