scientific-python / blog.scientific-python.org

Community blog posts on scientific-python.org
https://blog.scientific-python.org
Other
23 stars 33 forks source link

Numpy RNGs blog post #135

Closed albertcthomas closed 8 months ago

albertcthomas commented 1 year ago

Blog post on good practices with numpy RNGs (and RNGs in general but focused on numpy features). This is a blog post that I published on my personal page and @stefanv suggested to re-publish it here.

I should make sure it is up-to-date with the recent numpy developments. Some parts could also be changed. I'm opening the PR so we can start discussing about this post.

@stefanv (or anyone else,) let me know if you wanted to add something to this post

stefanv commented 1 year ago

@albertcthomas Thank you so much for this contribution! I have been on leave, but will review when I'm back.

albertcthomas commented 1 year ago

@albertcthomas Thank you so much for this contribution! I have been on leave, but will review when I'm back.

No worries. I'm also a bit slow on this... Thanks @tupui for the great comments, it's very appreciated to get some feedbacks on this post, I'm learning additional stuffs while doing this. I'll integrate them ASAP.

albertcthomas commented 11 months ago

No worries. I'm also a bit slow on this...

I dealt with the comments made by @tupui. I will just re-read what I wrote after getting some sleep and push it :)

albertcthomas commented 11 months ago

By the way I would like to add one sentence to thank the reviewers that made this blog post better than it was (like @tupui and others if I got other reviews) and other people like @stefanv for suggesting putting my blog post here. Is that OK with the scientific python blog?

tupui commented 11 months ago

Ok course, thank you 😃 This is really your post and we want to let people have their voice and write as their feel like. (And I hope we managed to do that here too 😅). We think it can be more interesting and engaging if we do as little editorial edits as possible to retain everyone's own intent, vision and ideas.

albertcthomas commented 11 months ago

I think I addressed all your comments @tupui. Let me know if there is anything left. Thanks again!

albertcthomas commented 11 months ago

Ok course, thank you 😃 This is really your post and we want to let people have their voice and write as their feel like. (And I hope we managed to do that here too 😅). We think it can be more interesting and engaging if we do as little editorial edits as possible to retain everyone's own intent, vision and ideas.

I will add one then.

Also could you please let me know before merging this PR? I'd like to read it one last time before it goes live :)

albertcthomas commented 11 months ago

Thanks a lot for the new reviews, I committed the easy suggestions, I will incorporate more of them later.

albertcthomas commented 8 months ago

Sorry again for the delay, everything looks good to me! Thanks again for the reviews and feedbacks. I'm not sure why pre-commit is failing... Not sure if I should also change the date of the blog post.

albertcthomas commented 8 months ago

Fixed the pre-commit!

albertcthomas commented 8 months ago

OK to merge for me if you have no further comments :). Thanks again for the constructive comments

stefanv commented 8 months ago

Excellent, I think we're good to go! Thanks so much @albertcthomas.

stefanv commented 8 months ago

In it goes! Thanks so much, Albert! 🎉

albertcthomas commented 8 months ago

Great! thanks a lot for reaching out and the reviews :)