search

scientific-python / blog.scientific-python.org

Community blog posts on scientific-python.org
https://blog.scientific-python.org
Other
23 stars 33 forks source link

Change: Condense and simplify all-posts page #137

Closed alphapapa closed 1 year ago

alphapapa commented 1 year ago

See https://github.com/scientific-python/blog.scientific-python.org/issues/130.

alphapapa commented 1 year ago

Will rebase this after https://github.com/scientific-python/blog.scientific-python.org/pull/144 is merged.

jarrodmillman commented 1 year ago

I am not sure #144 was needed, I already updated all the theme changes (other than the tag and changelog in #143). But I went ahead and merged it since it doesn't change anything. Once you rebase this on main, you should also set up your pre-commit hooks so the pre-commit bot is happy.

alphapapa commented 1 year ago

I am not sure #144 was needed, I already updated all the theme changes (other than the tag and changelog in #143). But I went ahead and merged it since it doesn't change anything. Once you rebase this on main, you should also set up your pre-commit hooks so the pre-commit bot is happy.

Rebased and pushed.

Will try to take the pre-commit config into account in the future, but am having some trouble getting it running securely locally.

jarrodmillman commented 1 year ago

pre-commit.ci autofix

stefanv commented 1 year ago

This LGTM. It would be nice to have the "All posts..." texts a bit more prominent, and make it clear that it is a link. Did it not have an arrow before?

The all posts page looks good; double checking that there still is pagination in place?

jarrodmillman commented 1 year ago

The remaining issue we were planning to deal with before merging this PR is removing the summaries from the actual posts page. I am marking this as a draft for now, so it isn't merged until that is addressed.

alphapapa commented 1 year ago

Here is what it looks like now:

@jarrodmillman Oops, I think you used the wrong deploy-preview link for the "now" screenshot (or maybe you accidentally duplicated the "before" screenshot). It doesn't look like that anymore. See https://deploy-preview-137--blog-scientific-python-org.netlify.app/ for this PR's current appearance.

@stefanv I'll adjust the "All posts..." link to be more prominent.

Thanks.

alphapapa commented 1 year ago

Latest changes visible here: https://github.com/scientific-python/blog.scientific-python.org/issues/130#issuecomment-1763035014 Which includes changes made to the theme here: https://github.com/scientific-python/scientific-python-hugo-theme/pull/289

Marking as ready for review.