Closed seberg closed 2 months ago
had thought @rgommers would do a major revision.
Sorry about the delay, and thanks a lot for pushing this forward! I had something unexpected come up. I'll work on updates over the next few hours.
Fix author (and more?)
I'd be fine with "NumPy Developers" as the author. Or names of folks who contribute here - either way works.
If we mention grants/institutional sponsers, I guess we need footnotes for the grants/details?
That will be both verbose and irrelevant to the average reader. This is not an academic publication, so we're not required to do this. I'd much prefer to leave out that info.
I've added Tidelift to the list of acknowledged sponsors, since its level of support has met the documented threshold for this kind of acknowledgement in https://numpy.org/neps/nep-0046-sponsorship-guidelines.html#how-numpy-will-acknowledge-support for multiple years. Other than that, I think the acknowledgements looked good.
I think this is in good shape now, and incorporates everything we discussed on Wednesday.
(I'm out for most of the day, will check back tonight)
I'm signing off for today - happy to ship this as is. If it slips to tomorrow, also not a big deal. After the post is published, we still have to link it from the News page on numpy.org
@stefanv maybe you could review too, and get it merged?
Thanks for the detailed copy-edit @stefanv! I applied all the ones that seemed like clear improvements; will comment on the few remaining ones.
I'm signing off for today - happy to ship this as is. If it slips to tomorrow, also not a big deal. After the post is published, we still have to link it from the News page on numpy.org
@stefanv maybe you could review too, and get it merged?
We can also update the text post-publication, as long as we have the important parts (title, e.g.!) in place.
green now
In it goes; thanks so much everyone!
Thanks for the great refactor and finishing it up yesterday @stefanv and @rgommers!
This is a draft trying to incorporate some of the things discussed last Wednesday. I had thought @rgommers would do a major revision. So this is a somewhat fresh start, which includes some of the things we discussed, but no idea if it at all what everyone had in mind. It doesn't include some of the more detailed notes added to the old draft, I had the intention to reduce details of changes rather, but of course maybe some of the "cool new things" get's lost that way...
I am not attached to this at all. There was hope a to release something on Sunday night shortly after the release to pypi. I don't know if that is viable now, since I expected to do a much smaller iteration today and be finished earlier.
Pinging some more active/involved ones with no particular order/logic: @stefanv, @charris, @rgommers, @mattip, @mhvk, @ngoldbaum, @mtsokol. Please don't hesitate to push changes (I'll invite you to my repo just in case).
Some things to do even if there is no big change:
pngquant
.