post about pypalettes - Githubissues

scientific-python / blog.scientific-python.org

Community blog posts on scientific-python.org

https://blog.scientific-python.org

Other

23 stars 33 forks source link

post about pypalettes #226

Open JosephBARBIERDARNAL opened 3 months ago

JosephBARBIERDARNAL commented 3 months ago

PyPalettes is a python library built on top of matplotlib that provides more than 2500 palettes, a simple API for using them and web app to browse/preview them.
[x] The main subject relates to at least one project affiliated to the Scientific Python Ecosystem: Matplotlib
[x] I have the right to publish the content under BSD 3-Clause License for the code and Creative Common CC-BY-4.0 License for the text.
[x] Images have been compressed using a tool like pngquant

JosephBARBIERDARNAL commented 3 months ago

Hello!

~I haven't been able to preview my post when running the site locally.~

~Everything seems to work fine (able to see the posts at http://localhost:1313/tags/matplotlib/).~

~Did I miss a step?~

Thanks

EDIT: solution found (:

PS: still a draft at the moment I'm writing this

stefanv commented 3 months ago

See licensing comments made on https://github.com/scientific-python/blog.scientific-python.org/pull/226/commits/bcb4eeaa87827431f65e4fe52af0e2316b642883

JosephBARBIERDARNAL commented 3 months ago

This PR can be merged! I'm perfectly open to feedback if any changes are necessary.

I've also made the changes related to the licensing issue.

JosephBARBIERDARNAL commented 1 month ago

Hey @stefanv ! I'm taking the liberty of sending you a ping to tell you that this PR can be merged (:

I've made the changes related to the licensing issue

stefanv commented 1 month ago

I am still not very comfortable with scraping another package's data, and presenting it as a new package. There is no mention of R paletteer outside of the license file.

Perhaps safest would be to ask whether @EmilHvitfeldt is OK with this type of usage, and hear what concerns they might have.

JosephBARBIERDARNAL commented 1 month ago

I'm not sure I understand. Scraping is only used for technical simplicity and paletteer is obviously also mentioned in the documentation acknowledgements (see https://github.com/JosephBARBIERDARNAL/pypalettes?tab=readme-ov-file#acknowledgements).

stefanv commented 1 month ago

I see the mention now, thanks for pointing it out. Still, I think best to get the thumbs-up from those who did the original work to aggregate all this data.

JosephBARBIERDARNAL commented 1 month ago

Yes, I can understand that. I'll add an explicit mention at the top of the README.

EmilHvitfeldt commented 1 month ago

I approve! if you need approval elsewhere please ping me

stefanv commented 1 month ago

Thanks, Emil!

JosephBARBIERDARNAL commented 1 month ago

Thanks to both of you!