scientific-python / blog.scientific-python.org

Community blog posts on scientific-python.org
https://blog.scientific-python.org
Other
23 stars 33 forks source link

Add NumPy Developer in Residence post #98

Closed stefanv closed 1 year ago

stefanv commented 1 year ago

@rgommers @InessaPawson

I've done some minor tightening up of the text (cleaned up some word repetition, modified Sayed's quote a bit to convey the right sentiment), so please scan the text one more time.

stefanv commented 1 year ago

I've noticed that the paragraph spacing on the blog is a bit tight, so I'll fix that up in the theme as well /cc @jarrodmillman

InessaPawson commented 1 year ago

@stefanv I've submitted my final suggestions.

rgommers commented 1 year ago

I've noticed that the paragraph spacing on the blog is a bit tight, so I'll fix that up in the theme as well /cc

I'd say line spacing is too large, paragraph spacing is too small, and font size is 2px too large. I didn't notice it on the previous blog post so much because it had section titles, but on the preview of this post the overall feel is off.

stefanv commented 1 year ago

@rgommers Does the latest preview look better?

rgommers commented 1 year ago

Much better! This looks good to go to me.

stefanv commented 1 year ago

OK, with approvals from you and Inessa, I'll go ahead and merge, but don't hesitate to reach out or make a PR if you notice something out of place later.

Thank you!

rgommers commented 1 year ago

Great, thanks Stefan and Inessa! I'll write to the numpy mailing list.