search

scientific-python / changelist

Prepare an automatic changelog from GitHub pull requests
BSD 3-Clause "New" or "Revised" License
8 stars 4 forks source link

Trailing comma after list of authors / reviewers #24

Closed stefanv closed 11 months ago

stefanv commented 11 months ago

Should be ','.join(authors).

May be better to format as a list instead?

lagru commented 11 months ago

Yeah. I think this was the result of me trying to implement the formatter as a line wise generator. Looking back that was probably overengineering on my part that just makes the code more complicated and leads to things such as this being harder / forgotten.