search

scientific-python / circleci-artifacts-redirector-action

GitHub Action to add a GitHub status link to a CircleCI artifact.
MIT License
14 stars 8 forks source link

Add url output #11

Closed bollwyvl closed 4 years ago

bollwyvl commented 4 years ago

Thanks for this action!

This adds an output which other steps can use. Perhaps I don't understand how it all works properly, but it seems like this might enable #10 through other actions, and let this action stay fairly simple.

choldgraf commented 4 years ago

btw @larsoner - I'm getting so much use out of this action :-) are there other ways that we could help to improve it?

larsoner commented 4 years ago

Thanks @bollwyvl ! Let me know if you need me to make a new release for this or something.

I'm getting so much use out of this action :-) are there other ways that we could help to improve it?

If people are bored, #7 needs fixing and someday it would be nice to have unit tests that actually test outputs. And (more fun) maybe now that this PR is in, someone could figure out how to combine the output with some other action to make #10 work!

bollwyvl commented 4 years ago

Thank you so much!

Tagged releases would be very helpful... @master gives me the willies.

As to testing... yeah, a first step might be to do the light port to typescript, as it can catch a bunch of stuff at transpile time, as most (all) of the upstreams are already typed, and it wouldn't add much to the build or runtime footprint. The circle payload would be mostly untyped, unfortunately. I guess a sufficient test would be with some fixtures of good and bad json.

larsoner commented 4 years ago

Tagged releases would be very helpful... @master gives me the willies.

https://github.com/larsoner/circleci-artifacts-redirector-action/releases/tag/0.2.0

As to testing...

My JavaScript knowledge is very limited, so I'm happy to review and merge any such fixes but at least to start I'm probably not the best person to implement them...

bollwyvl commented 4 years ago

Happy to oblige, might be a few days before I get the chance! JavaScript is indeed a terrible systems language, but here we are!