scientific-python / circleci-artifacts-redirector-action

GitHub Action to add a GitHub status link to a CircleCI artifact.
MIT License
14 stars 8 forks source link

Quick question to get this action to work again? #45

Open adam2392 opened 10 months ago

adam2392 commented 10 months ago

Hi,

For some reason I noticed that this Gh action stopped working awhile ago. Now https://github.com/neurodata/scikit-tree/actions/workflows/circle_artifacts.yml shows it is only trigged by codecov(?) but not run?

Here is my workflow file: https://github.com/neurodata/scikit-tree/blob/main/.github/workflows/circle_artifacts.yml Here is my circleCI docs build file: https://github.com/neurodata/scikit-tree/blob/main/.circleci/config.yml

I'm wondering if you can easily spot something that's not working?

larsoner commented 10 months ago

Can you check the updated readme in https://github.com/larsoner/circleci-artifacts-redirector-action#example-usage ? I suspect that you're missing some *-token

adam2392 commented 10 months ago

I uploaded a personal token to the repo

Screenshot 2023-09-20 at 10 19 11 AM

and then it seems I specified the right path

Screenshot 2023-09-20 at 10 20 14 AM

However, the action doesn't seem to get triggered: https://github.com/neurodata/scikit-tree/actions/workflows/circle_artifacts.yml

The PR in question I'm playing around w/ is: https://github.com/neurodata/scikit-tree/pull/125

Is it possible that:

  1. There is an issue if codecov is activated?
  2. Does the workflow need to get merged into main first before trying it out on a PR?
larsoner commented 10 months ago

The PR in question I'm playing around w/ is: neurodata/scikit-tree#125

You cannot test changes in a PR, the action that runs is the one that's in main, see this note in the README:

Note: The standard PR-to-main-repo-from-branch-in-a-fork workflow might not activate the action. For changes to take effect, changes might need to be made to to the default branch in a repo with the action enabled. For example, you could iterate directly in master, or in master of a fork. This seems to be a limitation of the fact that CircleCI uses the status (rather than app) API and that this is always tied to the master/default branch of a given repository.