search

scientific-python / cookie

Scientific Python Library Development Guide and Cookiecutter
https://learn.scientific-python.org/development
BSD 3-Clause "New" or "Revised" License
304 stars 54 forks source link

GH100 check looks for `.yml` and not `.yaml`, presumably #267

Closed Andrew-S-Rosen closed 1 year ago

Andrew-S-Rosen commented 1 year ago

https://scientific-python.github.io/repo-review/?repo=Quantum-Accelerators%2Fquacc&branch=main

In running the above test, GH100 gets raised and states that there are no .yml files in .github/workflows. While this is indeed true, there are .yaml files which are equally valid. This seems like a simple parsing issue.

henryiii commented 1 year ago

https://github.com/scientific-python/cookie/blob/f18ed30a366a6599a2275d4f2ab1256e62d7b9ba/src/sp_repo_review/checks/github.py#L20

(Globbing, technically, not parsing)