search

scientific-python / lazy-loader

Populate library namespace without incurring immediate import costs
BSD 3-Clause "New" or "Revised" License
132 stars 20 forks source link

conda upload #33

Closed nstarman closed 1 year ago

nstarman commented 1 year ago

Is https://anaconda.org/conda-forge/lazy_loader this package?

stefanv commented 1 year ago

Looks like it, but it's outdated. @bmcfee, is this yours?

stefanv commented 1 year ago

I see @sugatoray is listed as the maintainer.

bmcfee commented 1 year ago

No - my PR for the 0.1 release has not yet merged https://github.com/conda-forge/lazy_loader-feedstock/pull/1

sugatoray commented 1 year ago

@bmcfee Thank you for your PR. I merged it. You are now a co-maintainer on the repository.

nstarman commented 1 year ago

Maybe https://github.com/OpenAstronomy/github-actions-workflows#build-and-publish-a-pure-python-package is useful for releasing to both pip and conda simultaneously.

stefanv commented 1 year ago

@hmaarrfk You indicated some interest in packaging lazy_loader? We are about to make a new release.

hmaarrfk commented 1 year ago

I can help but given the nature as a pure python package, i would simply add a bot automerge, and mostly forget about it.

Major changes and dependency changes should get caught by the pip check command that is already in place https://github.com/conda-forge/lazy_loader-feedstock/blob/main/recipe/meta.yaml#L30

https://conda-forge.org/docs/maintainer/infrastructure.html#conda-forge-admin-please-add-bot-automerge

I'm on conda-forge core, so I have the ability to help in the case that the existing maintainers are busy for whatever reason. Given the existence of maintainers, I don't see the need to get involved unless there are any challenges.

hmaarrfk commented 1 year ago

For example, I maintain an other package that is pure python, that I just added automerge to due to hte fact that i've often failed to keep up with releases: https://github.com/conda-forge/sphinx-copybutton-feedstock/issues/21

hmaarrfk commented 1 year ago

I see the conda-forge maintainers are already on this thread. Thank you both!

stefanv commented 1 year ago

OK, thanks Mark! In that case I think we can close this issue.

hmaarrfk commented 1 year ago

To be honest, i'm not sure how concerned you are about modern scikit-image making it to the defaults channel.

The explosion in tools that help improve packaging has made dependencies grow in recent years, and anaconda has lagged behind more and more it seems.

If you (we) care about being in the default channel, i would monitor: https://anaconda.org/main/scikit-image

and try to ping anaconda when you feel it is appropriate.

stefanv commented 1 year ago

We don't typically interfere with company distributions. Would you say it's correct for us to focus predominantly on PyPi and conda-forge?

hmaarrfk commented 1 year ago

I agree with the choice not to interfere.

I just wanted to bring it up.