Fix processing of scss - Githubissues

scientific-python / scientific-python-hugo-theme

Hugo theme based on the design for numpy.org

https://theme.scientific-python.org/

Other

19 stars 23 forks source link

Fix processing of scss #542

Closed jarrodmillman closed 8 months ago

jarrodmillman commented 8 months ago

Fix https://github.com/numpy/numpy.org/pull/732

netlify[bot] commented 8 months ago

Deploy Preview for scientific-python-hugo-theme ready!

Built without sensitive environment variables

Name	Link
Latest commit	7a90343fdbd3510cceeef1a81d20cab5af14995d
Latest deploy log	https://app.netlify.com/sites/scientific-python-hugo-theme/deploys/65f05364badbac0008e64390
Deploy Preview	https://deploy-preview-542--scientific-python-hugo-theme.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 82 Accessibility: 100 Best Practices: 100 SEO: 92 PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

stefanv commented 8 months ago

Could you explain what this change does?

stefanv commented 8 months ago

At some point we changed from iterating over filenames to iterating over resources. So, there's no need to get again.

stefanv commented 8 months ago

xref: https://github.com/gohugoio/hugo/issues/12214

stefanv commented 8 months ago

Details given in https://github.com/numpy/numpy.org/pull/732#issue-2176759475