search

scientific-python / upload-nightly-action

This action is used to upload nightly builds of your package.
https://anaconda.org/scientific-python-nightly-wheels
BSD 3-Clause "New" or "Revised" License
7 stars 10 forks source link

bot autoupdating downstream to new url #39

Open martinfleis opened 1 year ago

martinfleis commented 1 year ago

While discussing the change of the home for nightlies, @bsipocz mentioned that once all core packages are uploading to a new location, there is a way to automatically open PRs downstream, changing the url from the old scipy one to the new scientific-python.

@bsipocz was there an attempt to do that? I haven't noticed it in any of the packages I'm involved with. Given the scipy repository is now outdated, it would be good to roll this out. I understood that all the necessary pieces were ready.

matthewfeickert commented 1 year ago

there is a way to automatically open PRs downstream, changing the url from the old scipy one to the new scientific-python.

I may be wrong, but my understanding was that this would be done by people (maybe scripted) but not using a GitHub Actions workflow.

I haven't noticed it in any of the packages I'm involved with.

@martinfleis can you please link all the projects you want updated here that fit the current definitons of "core" (https://github.com/scientific-python/upload-nightly-action/issues/30#issuecomment-1671869193)?

martinfleis commented 1 year ago

my understanding was that this would be done by people

My understanding was that a bot can do this and that @bsipocz knows how to deploy that bot.

but not using a GitHub Actions workflow.

Probably not by GHA. I am not sure. I may be raising the question in the wrong repo...

can you please link all the projects you want updated here that fit the current definitons of "core"

It is not about core packages, it is about the TEST WITH NIGHTLY WHEELS part of the SPEC 4. A lot of non-core downstream packages were already testing against nightly wheels uploaded to pypi.anaconda.org/scipy-wheels-nightly. All those need to be updated. I can update those I maintain but there is a ton of maintainers not aware of the change. The bot should've resolved that.

matthewfeickert commented 1 year ago

My understanding was that a bot can do this

Okay great.

It is not about core packages, it is about the TEST WITH NIGHTLY WHEELS part of the SPEC 4. ... All those need to be updated. I can update those I maintain but there is a ton of maintainers not aware of the change. The bot should've resolved that.

Okay. A thing to note is that the example given in SPEC 4 leaves people open to possible security issues (that should get fixed) and the pattern given in

https://github.com/scientific-python/upload-nightly-action/blob/ae4395280cc54a849801b0db1d19bbcb816341f2/README.md?plain=1#L65-L70

(i.e. the index is scientific-python-nightly-wheels and the extra index is PyPI) should be used instead.

matthewfeickert commented 4 months ago

I'm going to close this as I think all users are now on the correct URL, but please comment if this isn't the case for anyone.

bsipocz commented 4 months ago

There are still a lot of github search finds for the old URL, but a large fraction are coming from old travis config files, or from forks (even though the search result should not bring those up), etc, so it makes sense to close this issue as an autobot would just create a good amount of noise at this point.

bsipocz commented 4 months ago

I go ahead and reopen this issue given the more recent feelings around the numpy 2.0 release, apparently ~90ish non-fork repos still have the old link in their [tox.ini](pypi.anaconda.org/scipy-wheels-nightly path:tox.ini NOT is:archived NOT is:fork) and ~30 in their [.github](pypi.anaconda.org/scipy-wheels-nightly path:.github NOT is:archived NOT is:fork). Having a quick look at least a part of those repos are legit: still maintained and indeed not forks or manual copies.