search

scientific-python / upload-nightly-action

This action is used to upload nightly builds of your package.
https://anaconda.org/scientific-python-nightly-wheels
BSD 3-Clause "New" or "Revised" License
7 stars 10 forks source link

CI: fix spelling of test package name #79

Closed bsipocz closed 7 months ago

bsipocz commented 7 months ago

python -m build --outdir ./dist tests/test_package now creates test_package-0.0.1.tar.gz and test_package-0.0.1-py3-none-any.whl thus this PR fixes the spelling for the CI to pass.

matthewfeickert commented 7 months ago

Ah yes. In hatchling v1.22.0

Metadata for the wheel target now defaults to the PKG-INFO metadata within source distributions

Nice.

henryiii commented 7 months ago

I thought hatchling has normalized SDist names for among time? Setuptools just changed to do it too, but I though hatching basically always did it?

henryiii commented 7 months ago

Yes, it’s setuptools: https://github.com/scientific-python/upload-nightly-action/blob/a5d8097406eb99827061cc20d199db55e82eef6b/tests/test_package/pyproject.toml#L2

All the other build backends have done this since nearly the beginning.

matthewfeickert commented 7 months ago

Oh right. I just totally forgot that I had to use setuptools in PR #27 because https://github.com/anaconda/anaconda-client/issues/676 blocks using hatchling. I should see if this is still the case.

edit: This is still the case for

https://github.com/scientific-python/upload-nightly-action/blob/a5d8097406eb99827061cc20d199db55e82eef6b/conda-lock.yml#L49-L50