scientific-python / upload-nightly-action

This action is used to upload nightly builds of your package.
https://anaconda.org/scientific-python-nightly-wheels
BSD 3-Clause "New" or "Revised" License
7 stars 10 forks source link

MAINT: Need to be explicit with action path while using pixi run too #98

Closed MridulS closed 1 month ago

MridulS commented 1 month ago

I missed this in https://github.com/scientific-python/upload-nightly-action/pull/96 but we need to be explicit while using pixi run too.

I was tripping into could not find pixi.toml or pyproject.toml which is configured to use pixi while on the pixi run step downstream.

I can use https://github.com/scipp/scipp/pull/3542 to test this outside of this repo. I'll ping here once that passes :)

* Provide '--manifest-path' option to 'pixi run' to ensure the environment is properly activated.

      --manifest-path <MANIFEST_PATH>
          The path to 'pixi.toml' or 'pyproject.toml'
matthewfeickert commented 1 month ago

I can use scipp/scipp#3542 to test this outside of this repo. I'll ping here once that passes :)

Thank you @MridulS. If I'm not immediately responsive please merge if things pass there.

matthewfeickert commented 1 month ago

@MridulS The action worked for you. :+1:

Your workflow failed

  while read -r package_name; do
    echo "Removing $package_name"
    pixi run anaconda --token "***" remove -f "$package_name"
  done < dev_wheels.txt
  shell: /usr/bin/bash -l {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.10.15/x64
    PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.10.15/x64/lib/pkgconfig
    Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.15/x64
    Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.15/x64
    Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.15/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.10.15/x64/lib
Removing scipp-nightly-wheels/scipp/24.9.2.dev8+g7d0cce6be
  × could not find pixi.toml or pyproject.toml which is configured to use pixi

but that's because in your PR you're trying to use pixi locally without any configs:

      - name: Delete old dev wheels from pypi.anaconda.org
        run: |
          while read -r package_name; do
            echo "Removing $package_name"
            pixi run anaconda --token "${{secrets.ANACONDA_NIGHTLY_WHEEL_TOKEN}}" remove -f "$package_name"
          done < dev_wheels.txt