scientificcomputing / scifem

Scientific finite element toolbox
https://scientificcomputing.github.io/scifem/
MIT License
15 stars 2 forks source link

handle scale->alpha parameter rename in 0.9 #43

Closed minrk closed 1 month ago

minrk commented 1 month ago

should fix nightly build after https://github.com/FEniCS/dolfinx/pull/3434

not sure if you care about maintaining this compatibility, or if you'd rather update to require 0.9.

jorgensd commented 1 month ago

For now the plan is to keep backwards compatibility for 1 version (i.e. 0.8 and main), (0.8, 0.9, main), (0.9,0.10, main). This looks good to me and should probably be propagated through the repo, as there are currently some if else statements that does inexact version handling