scientifichackers / flutter_pdf_viewer

A native PDF viewer for flutter.
MIT License
107 stars 40 forks source link

iOS pdf viewer #2

Open eugenio-tesio opened 6 years ago

eugenio-tesio commented 6 years ago

Is there any intention to do the iOS pdf viewer?

devxpy commented 6 years ago

If you can buy me a mac, sure!

Anyway, I believe @The-Redhat has solved it in his local testing but he doesn't have the time to integrate it into this plugin right now.

You can follow our discussion here

eugenio-tesio commented 6 years ago

Jeje, that's why i hate apple and love Android, you can develop in any platform.

Thanks for the info!

El lun., 30 jul. 2018 a las 19:25, Dev Aggarwal (notifications@github.com) escribió:

If you can buy me a mac, sure!

Anyway, I believe @The-Redhat https://github.com/The-Redhat has solved it in his local testing but he doesn't have the time to integrate it into this plugin (You can follow our discussion here https://github.com/flutter/flutter/issues/15406#issuecomment-405162195].

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pycampers/flutter_pdf_viewer/issues/2#issuecomment-409031850, or mute the thread https://github.com/notifications/unsubscribe-auth/AS_KXs08FCmsUTOuBVcaEJ69xibcOpY5ks5uL4fLgaJpZM4VnRP7 .

-- Eugenio Tesio Zetus - Soluciones Empresariales *División Sistemas eugenio@zetus.com.ar mauricio@zetus.com.ar eugenio@atto.com.ar mauricio@atto.com.ar (+549) 3564-15-599945 San Francisco - 2400 Pcia de Córdoba - Argentina*

Google MyBusiness http://zetus-soluciones.negocio.site/

albo1337 commented 6 years ago

Looking forward for iOS Support too. Is there anyone who can help us?

devxpy commented 6 years ago

@albo1337 I'll try merging the IOS part on my freind's mac. Can you please check if there are night mode, password and horizontal scroll options available on the iOS side?

albo1337 commented 6 years ago

@devxpy The problem is that I currently don't have my MacBook with me and I'm for 1 Month out of home... But as far as I know I did not implement the nightmode or the password functionality for iOS

albo1337 commented 6 years ago

Just to let you know: I am using the standard webview in iOS to display pdf.

eugenio-tesio commented 6 years ago

Hi NullPointer, i used this package to display a downloaded pdf, i don't know if is you case https://pub.dartlang.org/packages/open_file

El jue., 11 oct. 2018 a las 8:00, NullPointer (notifications@github.com) escribió:

Just to let you know: I am using the standard webview in iOS to display pdf.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pycampers/flutter_pdf_viewer/issues/2#issuecomment-428912854, or mute the thread https://github.com/notifications/unsubscribe-auth/AS_KXpSF7G6HwM-OVxhXeHMHWdIUwCfFks5ujyTPgaJpZM4VnRP7 .

-- Eugenio Tesio Zetus - Soluciones Empresariales *División Sistemas eugenio@zetus.com.ar mauricio@zetus.com.ar eugenio@atto.com.ar mauricio@atto.com.ar (+549) 3564-15-599945 San Francisco - 2400 Pcia de Córdoba - Argentina*

Google MyBusiness http://zetus-soluciones.negocio.site/

devxpy commented 6 years ago

@eugenio-tesio This plugin is for viewing pdf inside the flutter app itself, not for opening the file in a different app

devxpy commented 6 years ago

@albo1337

standard webview

I don't feel like that's acceptable at all. We already have flutter_webview_plugin for doing webviews.

This plugin is intended to show PDFs inside of a native pdf viewer.

albo1337 commented 6 years ago

Well iOS has the possibility to show pdf's in webview without external libraries. Why not showing it in a webview? Android can't so we had to implement a workaround for Android only.

devxpy commented 6 years ago

Android also has the ability to show webviews without any external library.

(EDIT - you do need to load pdfjs inside the webview, but no, you don't need pdfium android)

My point was -- what's the use of this plugin if all it does is show stuff in a webview?

Webviews are a mediocre experience at best. Try loading very large PDFs and the webview will probably lag really bad.

You also, cannot load a webview from raw bytes without touching the filesystem, something which is important when dealing with sensitive documents. (Correct me if this doesn't apply to iOS)

bjbelliveau commented 6 years ago

Any update on this?

devxpy commented 6 years ago

@albo1337 Are you aware of a solution on iOS that does not display in a web view?

Perhaps this?

albo1337 commented 6 years ago

If I find some time I'm going to research how to implement this in our solution @devxpy . I keep you updated

l-k22 commented 5 years ago

If I find some time I'm going to research how to implement this in our solution @devxpy . I keep you updated

Hi @albo1337 , is there any update on this request? I recently came across this package which says it supports iOS, it also supports appbar. https://pub.dartlang.org/packages/flutter_full_pdf_viewer

albo1337 commented 5 years ago

If I find some time I'm going to research how to implement this in our solution @devxpy . I keep you updated

Hi @albo1337 , is there any update on this request? I recently came across this package which says it supports iOS, it also supports appbar. https://pub.dartlang.org/packages/flutter_full_pdf_viewer

This is actually my repository and it supports ios and android pdf viewer. The only part which I did not find time to implement is the iOS webview replacement with the pdf viewer.

l-k22 commented 5 years ago

If I find some time I'm going to research how to implement this in our solution @devxpy . I keep you updated

Hi @albo1337 , is there any update on this request? I recently came across this package which says it supports iOS, it also supports appbar. https://pub.dartlang.org/packages/flutter_full_pdf_viewer

This is actually my repository and it supports ios and android pdf viewer. The only part which I did not find time to implement is the iOS webview replacement with the pdf viewer.

Opps, I should have tagged @devxpy not you. Great package, it's what I'm using now just wish it could do horizontal scrolling 👍

devxpy commented 5 years ago

@l-k22 And I wish apple stopped their monopoly of compilers and just let us do our work 😕

l-k22 commented 5 years ago

@devxpy , that would be nice. @albo1337 and devxpy, sorry to go off topic but would either of you know how to implement a search feature? The pdfs within the app are scientific books so the user will want to search for specific keywords.

devxpy commented 5 years ago

@l-k22 It's impossible for me, because the native PDF viewer lib I used doesn't support it.

@albo1337 Would probably be able to integrate such a feature, because he's using a webview IIRC. Given that apple would allow trivial access to text rendered on webview :)

l-k22 commented 5 years ago

Hello, I wondered if you have had any luck progressing with this issue, albo1337 seems to have gone dark. Thanks

devxpy commented 5 years ago

@I-k22, please make a new issue regarding the text selection feature. Text selection requires a pdf parsing library that has open access to the content being displayed from within dart.

I haven't had any luck finding such a library yet.

MTschannett commented 5 years ago

@devxpy I'd like to help with the IOs part. If you could help me getting started with which libraries to use or and which features are important.

I have access to a Mac and I'd like to use this library in one of my projects. If there is anything I could do, I'd be glad to help.

devxpy commented 5 years ago

I forgot to update you guys here, but I'm soon getting a Mac myself, courtesy of Jaaga Labs.

We actually just launched a production app that uses this plugin - Meghshla online

You may expect a proof of concept, and even stable ios compat sometime around last week of next month.

MTschannett commented 5 years ago

@devxpy that's some good news ^^. Hope you have fun with your Mac ^^

MaskyS commented 5 years ago

@devxpy How's it going :D

devxpy commented 5 years ago

@MaskyS Kinda stuffed with work with the sponsor. The ios pdf is definitely on our roadmap, please give me some time.

ammaratef45 commented 5 years ago

@devxpy I have a mac and I can help if you want.