Thank you for your positive feedback and for suggesting some improvements. I'm glad to hear that everything is working well for you. I agree with making the changes you suggested to the verbose advice.
Thank you, and good work!
Camila Abreu
From: Sofia Monteiro @.>
Sent: Sunday, April 7, 2024 7:06 PM
To: scientisst/BioSPPy @.>
Cc: camilabreu10 @.>; Author @.>
Subject: Re: [scientisst/BioSPPy] Update quality.py (PR #41)
@sofia3ms requested changes on this pull request.
Hello Camila, thank you for your great contribution and for adding the optional verbose comments! Everything seems to be working great, I only wanted to suggest a few changes to the verbose advice for the metrics you added. I believe this way they are a bit more clear, let me know if you agree
Hello Sofia!
Thank you for your positive feedback and for suggesting some improvements. I'm glad to hear that everything is working well for you. I agree with making the changes you suggested to the verbose advice.
Thank you, and good work!
Camila Abreu
From: Sofia Monteiro @.> Sent: Sunday, April 7, 2024 7:06 PM To: scientisst/BioSPPy @.> Cc: camilabreu10 @.>; Author @.> Subject: Re: [scientisst/BioSPPy] Update quality.py (PR #41)
@sofia3ms requested changes on this pull request.
Hello Camila, thank you for your great contribution and for adding the optional verbose comments! Everything seems to be working great, I only wanted to suggest a few changes to the verbose advice for the metrics you added. I believe this way they are a bit more clear, let me know if you agree
In biosppy/quality.pyhttps://github.com/scientisst/BioSPPy/pull/41#discussion_r1555020041:
⬇️ Suggested change
In biosppy/quality.pyhttps://github.com/scientisst/BioSPPy/pull/41#discussion_r1555020404:
⬇️ Suggested change
— Reply to this email directly, view it on GitHubhttps://github.com/scientisst/BioSPPy/pull/41#pullrequestreview-1985140994, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BGRZ6INZVSCAENMPAVU5IWLY4GDJ5AVCNFSM6AAAAABE565O5GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSOBVGE2DAOJZGQ. You are receiving this because you authored the thread.Message ID: @.***>