search

scientist-softserv / adventist_knapsack

Apache License 2.0
1 stars 0 forks source link

🐛 Fix for human_readable_label_name not defined #11

Closed ShanaLMoore closed 9 months ago

ShanaLMoore commented 9 months ago

When running a job that attached a file set we received errors because the private methods were missing from this project. They exist in an adventist override: https://github.com/scientist-softserv/adventist-dl/blob/main/app/indexers/hyrax/file_set_indexer.rb

ShanaLMoore commented 9 months ago

@laritakr I'm not sure what you mean, I copied it from here: https://github.com/scientist-softserv/adventist-dl/blob/main/app/indexers/hyrax/file_set_indexer.rb

We created a decorator but didn't pull over all of the methods. When we run jobs currently, it fails because they're missing but the indexer calls on them.

laritakr commented 9 months ago

@laritakr I'm not sure what you mean, I copied it from here: https://github.com/scientist-softserv/adventist-dl/blob/main/app/indexers/hyrax/file_set_indexer.rb

@ShanaLMoore Ah ok, I missed that you were just pulling in existing code... I thought you were overriding something new and was very confused.

Can you add back the comment explaining what is being overridden?