git diff 032f58450daf90a6db8e88a1279979fe524a3e0d > diff.patch

scientist-softserv / adventist_knapsack

Apache License 2.0

1 stars 0 forks source link

git diff 032f58450daf90a6db8e88a1279979fe524a3e0d > diff.patch #121

Closed ShanaLMoore closed 2 months ago

ShanaLMoore commented 2 months ago

pulled over code that was introduced in adventist-dl post knapsack, which is still using Hyku adventist_dev branch.

Issue:

https://github.com/scientist-softserv/adventist_knapsack/issues/184

My progress - I deleted items from diff.patch as I copied code over. Here's what's left:

diffs.patch

Pre edits: original_diffs.patch --stat original_diffs.patch

ShanaLMoore commented 2 months ago

I was expecting to see changes to Gemfile.lock since I added two gems to bundler.d 🤔 Did I do this right?

jeremyf commented 2 months ago

As I was reading through the code I realized my comments make most sense if Adventist is on the latest prime of Hyku, but they aren’t. So we have this knapsack situation where files may need to be in the knapsack until