scientist-softserv / adventist_knapsack

Apache License 2.0
1 stars 0 forks source link

:comet: General QA #140

Closed ShanaLMoore closed 2 months ago

ShanaLMoore commented 2 months ago

Summary

We originally knapsacked this project about 6 months ago. Since then, code has been introduced in adventist proper that was copied into knapsack but never tested from knapsack before going live. We quickly learned that just because it worked for adventist proper, knapsack may sometimes require additional attention and should've gotten another round of QA.

It may be worth spot checking some of the recently added to knapsack features (see commits in the patch file), in addition to the bugs Katharine has already discovered, to ensure application parity.

At the time this ticket was created, s2 (staging) still hosts pre-knapsack cut over code, which could be helpful for comparisons.

Related

Acceptance Criteria

NOTES

diffs since sha: 032f58450daf90a6db8e88a1279979fe524a3e0d

commit_messages.patch

current errors: https://scientist-inc.sentry.io/issues/?project=6745020&statsPeriod=1h