scientist-softserv / adventist_knapsack

Apache License 2.0

1 stars 0 forks source link

Remove display of public tag #152

Closed ShanaLMoore closed 1 month ago

ShanaLMoore commented 2 months ago

Summary

Remove the display of tags on the work show page

Acceptance Criteria

[ ] tags like 'public' should not be rendered to the user

Testing Instructions

[ ] Parity with pre knapsack cut over (ignore the red circle but notice that no tags display)

Notes

ref:

https://github.com/scientist-softserv/adventist_knapsack/issues/179

related?

https://github.com/scientist-softserv/adventist_knapsack/issues/613
https://gitlab.com/notch8/adventist-dl/-/issues/82 (it looks like this was previously implemented via css changes. We still have this code in the knapsack but perhaps the class names changed)

KatharineV commented 2 months ago

The public tag is no longer showing on ADL or SDAPI production. Thank you!

ShanaLMoore commented 2 months ago

QA: Fail ❌

This is hiding more than the title badges

Per LaRita:

[ ] The work show pages do not show the visibility.
[ ] Collection show pages do not show visibility.
[ ] Catalog search does not show visibility
[ ] File list on show page does not include visibility
[ ] Dashboard lists show permissions.
[ ] Fileset show page has visibility
[ ] Edit works views show visibility