search

scientist-softserv / adventist_knapsack

Apache License 2.0
1 stars 0 forks source link

Collection title displays white #196

Closed ShanaLMoore closed 2 months ago

ShanaLMoore commented 4 months ago

Story

ref: https://github.com/scientist-softserv/adventist_knapsack/issues/307 Another piece of weird styling revealed itself today. A collection homepage is showing the title in white font on a white background with raised text shadows. Usually, Hyku only shows me this view if I try to upload a banner to a collection page (and I never do that because the feature breaks collections so they can't be edited).

First screenshot below shows a Knapsack collection with weird homepage styling. Second screenshot shows the expected font look on a collection homepage with no banner image.

Image

Image

https://demo.adventist-knapsack-staging.notch8.cloud/collections/66de37df-a236-4a1f-a48b-8dbe145e7c46?locale=en

Acceptance Criteria

ADL PROD: image

Notes

ShanaLMoore commented 4 months ago

QA Results: Pass ✅

Tested on: DEMO - Staging Collection title is no longer white with a shadow, and matches adventist production's style.

Image

KatharineV commented 4 months ago

Agreed. ADL QA finds that collection names no longer show as white on white text, and the drop shadow is gone.