scientist-softserv / adventist_knapsack

Apache License 2.0

2 stars 0 forks source link

Replace SETTINGS_ env vars #2

Closed laritakr closed 1 year ago

laritakr commented 1 year ago

Story

Refs https://github.com/scientist-softserv/adventist_knapsack/issues/538

Compared to hyku readme, as well as other repos based on a more current Hyku to rename and/or remove settings vars.
Also alphabetized Hyku vars to simplify side-by-side comparisons.

Expected Behavior Before Changes

Files in /ops directory contained SETTINGS_ vars

Expected Behavior After Changes

All references to SETTINGS_ vars in are replaced or removed.

Screenshots / Video

Notes

THERE APPEARS TO BE NO HYKU EQUIVALENTS FOR

SETTINGSDEVISEINVITATION_FROM_EMAIL
SETTINGSZOOKEEPERCONNECTION_STR

kirkkwang commented 1 year ago

Looks good, i left just some questions