scientist-softserv / adventist_knapsack

Apache License 2.0
1 stars 0 forks source link

Remove the manifest builder's reliance on files other than the PDF #220

Closed laritakr closed 7 months ago

laritakr commented 7 months ago

Story

Refs

The above ticket added PDF.js as a fallback viewer in cases where the PDF splitting did not occur. However, in some cases, PDF splitting DOES occur, but due to files other than the PDF not getting attached, the manifest builder service fails.

Work showing this problem: https://adl.b2.adventistdigitallibrary.org/concern/published_works/20187969_columbia_union_visitor_march_22_1928?locale=en

We want to display the viewer in cases where the PDF has split into child works rather than the black box because of the manifest builder throwing a 500 error.

Acceptance Criteria

Screenshots / Video

![Screenshot 2023-11-27 at 4 55 04 PM](https://github.com/scientist-softserv/adventist-dl/assets/17851674/4387394a-0bae-444b-987f-74b2a6e5db9a) ![Screenshot 2023-11-27 at 4 55 13 PM](https://github.com/scientist-softserv/adventist-dl/assets/17851674/5569dffa-1558-483c-bf9c-d36a4c7a62d2)

Testing Instructions and Sample Files

-

Notes