Metadata fields not showing on Work public view

[KatharineV]

Some metadata fields can have content entered on the edit screen, but when I save, the content is not present on the user view. The fields don't show up at all. Some of these are new metadata fields in Knapsack that I can't test against our existing Hyku. Some of the fields are in the older version and I can confirm that they show on ADL prod but not in Knapsack.

New Fields:

• Access Rights
• Rights Notes

Screenshot of edit screen of this work.

Existing fields:

• License (see it displaying on prod here)
• Publication status (on prod here)

Work types affected:

• Published Work (license)
• Conference Item (all fields)
• Journal Article (license, publication status)
• Exam Paper (Access rights, rights notes, license)
• Dataset (Access rights, rights notes, license)
• Thesis (Access rights, rights notes, license)
• Images (Access rights, rights notes, license--can't even enter data into these fields because trying to save generates "We're sorry, but something went wrong" message)
• Generic Work (Access rights, rights notes, license--can't enter data right now because of "We're sorry, but something went wrong" error message)

Testing Instructions

Create a work of each work type, filling in each term. Ensure that each term appears on the show view for the work.

Terms by work type

The expected terms for each type of work are listed below, along with their sequences on the form and show pages. 

Screenshots showing new terms

 

[laritakr]

You are referring to some existing terms that your current app has specifically from being shown on the works: Conference Items, Datasets, Journal Articles, Published Works and Theses exclude description and license (they show abstract) Exam Papers exclude license Generic Works and Images should show all terms

Rights Notes and Access Rights are new terms for all work types, but they were for some reason excluded from Journal Articles. They can either be excluded from other work types, or made to appear on the show view - do you have a preference?

[KatharineV]

@laritakr I may not be understanding correctly, so please bear with me. I didn’t know that my predecessor had the team suppress any fields from any work types. There is no reason I can think of for why we would suppress any fields. So, I would ask for all new fields to appear in our version of Hyku on every work type where they are intended to appear. This applies to Rights Notes and Access Rights, I understand.

As for the other fields, forget I mentioned them I guess. My predecessor kept literally no documentation of decisions he made like fields to suppress, so I had no way of knowing what to look for. My apologies for wasting your time. It is very difficult to do this testing in the dark. I am doing my best.

[laritakr]

No worries, Katharine... this is confusing for both of us!

I am doing some verification and we're trying to do some cleanup in the code to make this more straightforward for the future. I put together a spreadsheet where I am verifying the metadata, so I may have more questions next week. I appreciate your patience as I try to figure it out. :) But unless you have a reason to suppress any fields from showing, I intend to have them show.

[laritakr]

I will add that publication status is DEFINITELY a bug... it is not persisting on the work so it does not display. I will continue working to get this resolved.

[KatharineV]

Thanks, LaRita. I agree that there's no reason to suppress any fields. If we don't enter metadata on the backend, they don't show on the front, so that's a fine solution. I can't think of any reason to redact a field from the backend, thereby making it inaccessible for future use, as if I know all the possible future use cases for our instance of Hyku. I don't have that much hubris. So, yes, please do make anything show that is available, and I'll plan for a future maintenance ticket to release the fields that were suppressed in earlier rounds of work under a different mindset.

Thank you also for catching publication status. That one is weird!

[kirkkwang]

QA Results

• Conference Item ✅
• Dataset ✅
• Exam Paper✅
• Journal Article ✅
• Published Work ✅
• Thesis ✅
• Generic Work ✅
• Image ✅

Notes

These are non-blocking but worth noting:

I couldn't test the Location probably because GeoName isn't set up on staging.

I'm noticing an in consistency with the date fields

Sometimes it's doing MM/DD/YYYY and sometimes DD/MM/YYYY, first one should be November 1st and second one is November 9th.

[kirkkwang]

with regards to the date appearing weird, this PR seems to address it

[KatharineV]

Fields are showing as expected on Knapsack Demo. I created all new works of every type today, and I filled in every field. With the exception of those that were intentionally suppressed in the past, all fields show on the user side now.