scientist-softserv / adventist_knapsack

Apache License 2.0
1 stars 0 forks source link

Work page "Add to Collection" button does not work #249

Open KatharineV opened 9 months ago

KatharineV commented 9 months ago

While logged into demo.adventist-knapsack as an admin, I can see the "Add to collection" action button on a work's page. However, the button does not work. I cannot add to any collections.

I tried to add this work to two collections. One was already existing and I didn't create it. I created a second one just for the test, to confirm that it wasn't a permissions issue. I could not generate either collection name from the "Add to Collection" action button dropdown, so I couldn't add it to either collection.

Screenshots illustrating issue ![Image](https://github.com/scientist-softserv/adventist-dl/assets/118196520/65acd7cf-b306-47cb-8670-c4aaf6e8b669) ![Image](https://github.com/scientist-softserv/adventist-dl/assets/118196520/580f4f8a-5126-4d45-8fbf-0eb53cb1003c) ![Image](https://github.com/scientist-softserv/adventist-dl/assets/118196520/1b13a245-92ef-40d7-9185-6f99cc1b24dc)

Testing Instructions

Be sure you have one or more collections available to work with. Add works to a collection through each of the options:

jillpe commented 8 months ago

SoftServ QA

Image

Image

Image

Image

Image

laritakr commented 8 months ago

relates to https://github.com/samvera/hyku/pull/2024

ShanaLMoore commented 4 months ago

QA RESULTS: PASS ✅

KatharineV commented 4 months ago

ADL QA Results - **Partial pass. Failure to search collections on single word**, which is functionality that exists in our current production instance.

  1. select one or more works from the dashboard list of works, and use the "Add to collection" button Does NOT work if we search a single word of the collection name. Did work when I searched two words of a collection name. Unfortunately, we must have functionality with one word searches. The drop down says the search will work with only 2 characters. That has never worked, but Hyku has worked to search collections with a single word prior to Knapsack, and we need Knapsack to have the same functionality.

Failure to search on one word: Image

Found the collection with two words: Image

ADL production dropdown finds collections with single word search: Image

  1. open a work's show page, and use the "Add to collection" button Does NOT work if we search a single word of the collection name. Did work when I searched two words of a collection name. Unfortunately, we must have functionality with one word searches.

  2. open a collection in the dashboard, and select "Add existing works to this collection" WORKED as expected

  3. go to second page on dashboard works list. select one or more works and use the "Add to collection" button WORKED as expected

ShanaLMoore commented 2 months ago

A better solution is in place in Hyku main, which adventist will receive once we complete their upgrade. This may be a temporary inconvenience, but Rob said we've fixed this before in other projects so it's worth looking through repos.

ShanaLMoore commented 2 months ago

related to: https://github.com/scientist-softserv/adventist-dl/issues/623

KatharineV commented 1 month ago

Team, when I tested in February, I could add existing works to existing collections. Today I cannot (on ADL production--will add a comment if other environments behave differently). I get an error message if I try to add using the "Add to collection" button on a work page, if I go to a collection and choose "add existing works," and if I page through the dashboard and try to add works to collections. Nothing is effective to add works to collections right now. :(

laritakr commented 1 month ago

If you click on the collection inside the dashboard, I believe you should be able to add works using the options on that view. I would be interested to know if this will work.

Screenshot 2024-05-14 at 12 35 03 PM