scientist-softserv / adventist_knapsack

Apache License 2.0

1 stars 0 forks source link

OCR issues #260

Closed ShanaLMoore closed 2 months ago

ShanaLMoore commented 9 months ago

Summary

OCR search is not highlighting as expected

Acceptance Criteria

When searching for OCR, if there's a match it should:

[ ] be highlighted in the catalog search results as a "snippet"
[ ] auto fill the Universal Viewer and highlight the matches, by clicking into the work from the catalog search results
[ ] A user should also be able to manually type a search into the UV and get highlighted matches

Testing Instructions

From the catalog search page search for the word 'lamp' You should find a match, and the word 'lamp' will be highlighted in the search results click into the work the word lamp should auto search the universal viewer and highlight a match manually try typing other words. If there's a match, it should be found and highlighted. If there's not, it won't.

STAGING EXAMPLE

Searched for "stare" then clicked into the work

KNAPSACK

Manually typing "stare" in the UV:

ShanaLMoore commented 9 months ago

Note from Kirk:

'after reindexing your work, it’s members, and its file sets, the search works https://demo.adventist-knapsack-staging.notch8.cloud/concern/generic_works/1234567_cat_scan'

ShanaLMoore commented 8 months ago

I naturally started to QA this while assisting Jill with testing instructions. ❌

Sending this back for work. In staging clicking into the work does not auto search the UV

Demo:

https://github.com/scientist-softserv/adventist-dl/assets/10081604/b2726157-03d3-48ad-9f72-8122682f20b4

kirkkwang commented 8 months ago

Something weird to start with, it's looking for manifest.json in the public folder it seems and of course it's getting a 404. Also, just now Shana clicked on a work and it DID do it, the console errors about the manifest.json were not observed so they do seem related.

ShanaLMoore commented 8 months ago

This appears to suddenly be working again on staging 🤔 demo:

Screen Recording 2023-10-10 at 10 11 59 AM

jillpe commented 8 months ago

SoftServ QA: ✅ Pass

[x] be highlighted in the catalog search results as a "snippet"
[x] auto fill the Universal Viewer and highlight the matches, by clicking into the work from the catalog search results
[x] A user should also be able to manually type a search into the UV and get highlighted matches

Screenshots

![Image](https://github.com/scientist-softserv/adventist-dl/assets/84697174/63a31a5f-83a1-4473-ad6e-0f4e3746245c) https://github.com/scientist-softserv/adventist-dl/assets/84697174/315a1334-23cc-42e1-ba66-f48713ffd001 ![Image](https://github.com/scientist-softserv/adventist-dl/assets/84697174/e87250db-28ff-4fc0-877b-9229a928503f)