scientist-softserv / adventist_knapsack

Apache License 2.0

1 stars 0 forks source link

Custom Font Issues #279

Closed laritakr closed 2 months ago

laritakr commented 9 months ago

1. Double Rendering

Font selection works in spite of the duplication of select fields.

[x] Font input should only show once on tab

2. No Font Preview

[x] Font options shows a preview of what the font looks like

Staging examples

Testing Instructions

Visit https://demo.adventist-knapsack-staging.notch8.cloud/admin/appearance?locale=en#font (Admin Dashboard > Settings > Appearance > Font Tab

[ ] DOUBLE RENDERING: There should be 1 input field for each option (Select Body Font and Select Header Font)
[ ] NO FONT DEFAULT PREVIEW:
- Disregard. This is a known bug in hyku that we will not fix in this epic of work. Currently the user has to select an option of the dropdown to see the fonts displayed.

ShanaLMoore commented 9 months ago

commenting out the javascript makes the input fields render once 🤔

or commenting this out works too.

javascript library comes from: https://github.com/tommoor/fontselect-jquery-plugin/blob/master/jquery.fontselect.js

ShanaLMoore commented 9 months ago

There's something about fontselect that adds another input field. I've since confirmed that this is happening on hyku proper's main, as well:

I think this is happening because the two javascript files w font select are being called twice. I'm not sure why this would suddenly fail since the code isn't new, but removing one of these js files should solve the double rendering problem.

ShanaLMoore commented 9 months ago

There is a known bug in hyku regarding the font display in the dropdown. For now you will have to click into a drop down option before it will update its rendering. This is out of scope to fix now and the fix should go back to hyku.

ShanaLMoore commented 9 months ago

font needs to be https://fonts.googleapis.com/css?family=Nobile|sans-serif

jillpe commented 9 months ago

SoftServ QA: ✅ Pass

[x] DOUBLE RENDERING: There should be 1 input field for each option (Select Body Font and Select Header Font)
[x] NO FONT DEFAULT PREVIEW:
- Disregard. This is a known bug in hyku that we will not fix in this epic of work. Currently the user has to select an option of the dropdown to see the fonts displayed.

Screenshots

![Image](https://github.com/scientist-softserv/adventist-dl/assets/84697174/69278fab-f243-4319-91f9-e0bca95bba64) ![Image](https://github.com/scientist-softserv/adventist-dl/assets/84697174/c67cdd1d-b0b8-4c1e-a469-2f5bd8f120a7)